Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1cd2b13 authored by Srivatsa S. Bhat's avatar Srivatsa S. Bhat Committed by Ingo Molnar
Browse files

cpusets: Remove/update outdated comments 



cpuset_track_online_cpus() is no longer present. So remove the
outdated comment and replace it with reference to cpuset_update_active_cpus()
which is its equivalent.

Also, we don't lack memory hot-unplug anymore. And David Rientjes pointed
out how it is dealt with. So update that comment as well.

Signed-off-by: default avatarSrivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20120524141700.3692.98192.stgit@srivatsabhat.in.ibm.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 7ddf96b0

kernel/cpuset.c

+3 −4
Original line number Diff line number Diff line
@@ -2034,9 +2034,8 @@ static struct cpuset *cpuset_next(struct list_head *queue) 
 * before dropping down to the next.  It always processes a node before

 * any of its children.

 *

 * For now, since we lack memory hot unplug, we'll never see a cpuset

 * that has tasks along with an empty 'mems'.  But if we did see such

 * a cpuset, we'd handle it just like we do if its 'cpus' was empty.

 * In the case of memory hot-unplug, it will remove nodes from N_HIGH_MEMORY

 * if all present pages from a node are offlined.

 */

static void

scan_cpusets_upon_hotplug(struct cpuset *root, enum hotplug_event event)
@@ -2137,7 +2136,7 @@ void cpuset_update_active_cpus(bool cpu_online) 
/*

 * Keep top_cpuset.mems_allowed tracking node_states[N_HIGH_MEMORY].

 * Call this routine anytime after node_states[N_HIGH_MEMORY] changes.

 * See also the previous routine cpuset_track_online_cpus().

 * See cpuset_update_active_cpus() for CPU hotplug handling.

 */

static int cpuset_track_online_nodes(struct notifier_block *self,

				unsigned long action, void *arg)