Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a1a50c8e authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

fsl/man: Inherit parent device and of_node 



Junote Cai reported that he was not able to get a DSA setup involving the
Freescale DPAA/FMAN driver to work and narrowed it down to
of_find_net_device_by_node(). This function requires the network device's
device reference to be correctly set which is the case here, though we have
lost any device_node association there.

The problem is that dpaa_eth_add_device() allocates a "dpaa-ethernet" platform
device, and later on dpaa_eth_probe() is called but SET_NETDEV_DEV() won't be
propagating &pdev->dev.of_node properly. Fix this by inherenting both the parent
device and the of_node when dpaa_eth_add_device() creates the platform device.

Fixes: 39339616 ("fsl/fman: Add FMan MAC driver")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 33ba43ed

drivers/net/ethernet/freescale/fman/mac.c

+2 −0
Original line number Diff line number Diff line
@@ -623,6 +623,8 @@ static struct platform_device *dpaa_eth_add_device(int fman_id, 
		goto no_mem;

	}



	pdev->dev.of_node = node;

	pdev->dev.parent = priv->dev;

	set_dma_ops(&pdev->dev, get_dma_ops(priv->dev));



	ret = platform_device_add_data(pdev, &data, sizeof(data));