Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a108193c authored by Dan Carpenter's avatar Dan Carpenter Committed by Dmitry Torokhov
Browse files

Input: tnetv107x-keypad - make irqs signed for error handling 



There is a bug in keypad_probe() where we do:

	kp->irq_press   = platform_get_irq_byname(pdev, "press");
	kp->irq_release = platform_get_irq_byname(pdev, "release");
	if (kp->irq_press < 0 || kp->irq_release < 0) {

The problem is that these irq variables are unsigned so the error
handling doesn't work.  I've changed them to signed values.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent c6d81bd7

drivers/input/keyboard/tnetv107x-keypad.c

+2 −2
Original line number Diff line number Diff line
@@ -60,8 +60,8 @@ struct keypad_data { 
	struct clk			*clk;

	struct device			*dev;

	spinlock_t			lock;

	u32				irq_press;

	u32				irq_release;

	int				irq_press;

	int				irq_release;

	int				rows, cols, row_shift;

	int				debounce_ms, active_low;

	u32				prev_keys[3];