Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0e90245 authored by Rusty Russell's avatar Rusty Russell Committed by Ingo Molnar
Browse files

sched: convert rebalance_domains() to cpumask_var_t. 



Impact: stack usage reduction

Dynamically allocating cpumasks (when CONFIG_CPUMASK_OFFSTACK) saves
space in the stack.  cpumask_var_t is just a struct cpumask for
!CONFIG_CPUMASK_OFFSTACK.

Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 4d2732c6

kernel/sched.c

+8 −2
Original line number Diff line number Diff line
@@ -3850,7 +3850,11 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle) 
	unsigned long next_balance = jiffies + 60*HZ;

	int update_next_balance = 0;

	int need_serialize;

	cpumask_t tmp;

	cpumask_var_t tmp;



	/* Fails alloc?  Rebalancing probably not a priority right now. */

	if (!alloc_cpumask_var(&tmp, GFP_ATOMIC))

		return;



	for_each_domain(cpu, sd) {

		if (!(sd->flags & SD_LOAD_BALANCE))
@@ -3875,7 +3879,7 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle) 
		}



		if (time_after_eq(jiffies, sd->last_balance + interval)) {

			if (load_balance(cpu, rq, sd, idle, &balance, &tmp)) {

			if (load_balance(cpu, rq, sd, idle, &balance, tmp)) {

				/*

				 * We've pulled tasks over so either we're no

				 * longer idle, or one of our SMT siblings is
@@ -3909,6 +3913,8 @@ static void rebalance_domains(int cpu, enum cpu_idle_type idle) 
	 */

	if (likely(update_next_balance))

		rq->next_balance = next_balance;



	free_cpumask_var(tmp);

}



/*