Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a09c94d0 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Fix possible side-effects in _batadv_dbg 



An argument of a macro should not be evaluated multiple times. Otherwise
embedded operations in these arguments will be executed multiple times.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 1fda4c0a

net/batman-adv/log.h

+3 −2
Original line number Diff line number Diff line
@@ -73,9 +73,10 @@ __printf(2, 3); 
/* possibly ratelimited debug output */

#define _batadv_dbg(type, bat_priv, ratelimited, fmt, arg...)		\

	do {								\

		if (atomic_read(&(bat_priv)->log_level) & (type) &&	\

		struct batadv_priv *__batpriv = (bat_priv);		\

		if (atomic_read(&__batpriv->log_level) & (type) &&	\

		    (!(ratelimited) || net_ratelimit()))		\

			batadv_debug_log(bat_priv, fmt, ## arg);	\

			batadv_debug_log(__batpriv, fmt, ## arg);	\

	}								\

	while (0)

#else /* !CONFIG_BATMAN_ADV_DEBUG */