Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a0732548 authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by David S. Miller
Browse files

net: tipc: bcast: Replace GFP_ATOMIC with GFP_KERNEL in tipc_bcast_init() 



tipc_bcast_init() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 04b9ce48

net/tipc/bcast.c

+1 −1
Original line number Diff line number Diff line
@@ -512,7 +512,7 @@ int tipc_bcast_init(struct net *net) 
	struct tipc_bc_base *bb = NULL;

	struct tipc_link *l = NULL;



	bb = kzalloc(sizeof(*bb), GFP_ATOMIC);

	bb = kzalloc(sizeof(*bb), GFP_KERNEL);

	if (!bb)

		goto enomem;

	tn->bcbase = bb;