Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9fd93784 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: remove return value from drm_helper_mode_fill_fb_struct 



Rightfully no driver ever checked this - it can't fail.

Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 9ee984a5

drivers/gpu/drm/drm_crtc_helper.c

+2 −4
Original line number Diff line number Diff line
@@ -923,7 +923,7 @@ void drm_helper_connector_dpms(struct drm_connector *connector, int mode) 
}

EXPORT_SYMBOL(drm_helper_connector_dpms);



int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,

void drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,

				    struct drm_mode_fb_cmd2 *mode_cmd)

{

	int i;
@@ -937,8 +937,6 @@ int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb, 
	drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,

				    &fb->bits_per_pixel);

	fb->pixel_format = mode_cmd->pixel_format;



	return 0;

}

EXPORT_SYMBOL(drm_helper_mode_fill_fb_struct);

include/drm/drm_crtc_helper.h

+2 −2
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ extern void drm_helper_connector_dpms(struct drm_connector *connector, int mode) 


extern void drm_helper_move_panel_connectors_to_head(struct drm_device *);



extern int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,

extern void drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,

					   struct drm_mode_fb_cmd2 *mode_cmd);



static inline void drm_crtc_helper_add(struct drm_crtc *crtc,