Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9faa730f authored by Sridhar Samudrala's avatar Sridhar Samudrala Committed by David S. Miller
Browse files

[SCTP]: Set chunk->data_accepted only if we are going to accept it. 



Currently there is a code path in sctp_eat_data() where it is possible
to set this flag even when we are dropping this chunk.

Signed-off-by: default avatarSridhar Samudrala <sri@us.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ad8fec17

net/sctp/sm_statefuns.c

+2 −1
Original line number Diff line number Diff line
@@ -5283,7 +5283,6 @@ static int sctp_eat_data(const struct sctp_association *asoc, 
	datalen -= sizeof(sctp_data_chunk_t);



	deliver = SCTP_CMD_CHUNK_ULP;

	chunk->data_accepted = 1;



	/* Think about partial delivery. */

	if ((datalen >= asoc->rwnd) && (!asoc->ulpq.pd_mode)) {
@@ -5362,6 +5361,8 @@ static int sctp_eat_data(const struct sctp_association *asoc, 
	if (SCTP_CMD_CHUNK_ULP == deliver)

		sctp_add_cmd_sf(commands, SCTP_CMD_REPORT_TSN, SCTP_U32(tsn));



	chunk->data_accepted = 1;



	/* Note: Some chunks may get overcounted (if we drop) or overcounted

	 * if we renege and the chunk arrives again.

	 */