Commit 9fa34a1e authored May 07, 2013 by Jingoo Han Committed by David Woodhouse Aug 05, 2013

mtd: devices: spear_smi: remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d063
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>

parent 399b6b7d

drivers/mtd/devices/spear_smi.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -995,14 +995,12 @@ static int spear_smi_probe(struct platform_device *pdev)
		ret = spear_smi_setup_banks(pdev, i, pdata->np[i]);
		if (ret) {
		dev_err(&dev->pdev->dev, "bank setup failed\n");
		goto err_bank_setup;
		goto err_irq;
		}
		}

		return 0;

		err_bank_setup:
		platform_set_drvdata(pdev, NULL);
		err_irq:
		clk_disable_unprepare(dev->clk);
		err:
		@@ -1040,7 +1038,6 @@ static int spear_smi_remove(struct platform_device *pdev)
		}

		clk_disable_unprepare(dev->clk);
		platform_set_drvdata(pdev, NULL);

		return 0;
		}