Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9f7b16af authored by Andrew Boyer's avatar Andrew Boyer Committed by Doug Ledford
Browse files

RDMA/i40iw: Avoid reference leaks when processing the AEQ 



In this switch there is a reference held on the QP. 'continue' will grab
the next event without releasing the reference, causing a leak.

Change it to 'break' to drop the reference before grabbing the next event.

Fixes: 4e9042e6 ("i40iw: add hw and utils files")
Signed-off-by: default avatarAndrew Boyer <andrew.boyer@dell.com>
Reviewed-by: default avatarShiraz Saleem <shiraz.saleem@intel.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent a75895b1

drivers/infiniband/hw/i40iw/i40iw_hw.c

+2 −2
Original line number Diff line number Diff line
@@ -331,7 +331,7 @@ void i40iw_process_aeq(struct i40iw_device *iwdev) 
		switch (info->ae_id) {

		case I40IW_AE_LLP_FIN_RECEIVED:

			if (qp->term_flags)

				continue;

				break;

			if (atomic_inc_return(&iwqp->close_timer_started) == 1) {

				iwqp->hw_tcp_state = I40IW_TCP_STATE_CLOSE_WAIT;

				if ((iwqp->hw_tcp_state == I40IW_TCP_STATE_CLOSE_WAIT) &&
@@ -360,7 +360,7 @@ void i40iw_process_aeq(struct i40iw_device *iwdev) 
			break;

		case I40IW_AE_LLP_CONNECTION_RESET:

			if (atomic_read(&iwqp->close_timer_started))

				continue;

				break;

			i40iw_cm_disconn(iwqp);

			break;

		case I40IW_AE_QP_SUSPEND_COMPLETE: