Commit 9ec36f7f authored Feb 02, 2015 by Felipe Balbi

usb: gadget: function: phonet: balance usb_ep_disable calls



f_phonet's ->set_alt() method will call usb_ep_disable()
potentially on an endpoint which is already disabled. That's
something the gadget/function driver must guarantee that it's
always balanced.

In order to balance the calls, just make sure the endpoint
was enabled before by means of checking the validity of
driver_data.

Reported-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent 20357720

drivers/usb/gadget/function/f_phonet.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -417,7 +417,10 @@ static int pn_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
		return -EINVAL;

		spin_lock(&port->lock);

		if (fp->in_ep->driver_data)
		__pn_reset(f);

		if (alt == 1) {
		int i;