Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ebae9e4 authored by Alan Cox's avatar Alan Cox Committed by Tejun Heo
Browse files

pata_ninja32: Avoid corrupting status flags 



Ninja32 needs to set some flags to indicate it does 32bit IO. However it currently assigns this which
loses the initializing flag and causes a warning spew. Fix it to use a logical or as is intended.

Signed-off-by: default avatarAlan Cox <alan@linux.intel.com>
Tested-by: default avatarEllmar Stelnberger <estellnb@elstel.org>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 9b4b3f6a

drivers/ata/pata_ninja32.c

+1 −1
Original line number Diff line number Diff line
@@ -144,7 +144,7 @@ static int ninja32_init_one(struct pci_dev *dev, const struct pci_device_id *id) 
	ap->ioaddr.altstatus_addr = base + 0x1E;

	ap->ioaddr.bmdma_addr = base;

	ata_sff_std_ports(&ap->ioaddr);

	ap->pflags = ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;

	ap->pflags |= ATA_PFLAG_PIO32 | ATA_PFLAG_PIO32CHANGE;



	ninja32_program(base);

	/* FIXME: Should we disable them at remove ? */