Commit 9e56921e authored Jul 14, 2021 by Colin Ian King Committed by Greg Kroah-Hartman Jul 28, 2021

liquidio: Fix unintentional sign extension issue on left shift of u16



[ Upstream commit e7efc2ce3d0789cd7c21b70ff00cd7838d382639 ]

Shifting the u16 integer oct->pcie_port by CN23XX_PKT_INPUT_CTL_MAC_NUM_POS
(29) bits will be promoted to a 32 bit signed int and then sign-extended
to a u64. In the cases where oct->pcie_port where bit 2 is set (e.g. 3..7)
the shifted value will be sign extended and the top 32 bits of the result
will be set.

Fix this by casting the u16 values to a u64 before the 29 bit left shift.

Addresses-Coverity: ("Unintended sign extension")

Fixes: 3451b97c ("liquidio: CN23XX register setup")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent bd0447f7

drivers/net/ethernet/cavium/liquidio/cn23xx_pf_device.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -420,7 +420,7 @@ static int cn23xx_pf_setup_global_input_regs(struct octeon_device *oct)
	* bits 32:47 indicate the PVF num.		* bits 32:47 indicate the PVF num.
	*/		*/
	for (q_no = 0; q_no < ern; q_no++) {		for (q_no = 0; q_no < ern; q_no++) {
	reg_val = oct->pcie_port << CN23XX_PKT_INPUT_CTL_MAC_NUM_POS;		reg_val = (u64)oct->pcie_port << CN23XX_PKT_INPUT_CTL_MAC_NUM_POS;

	/* for VF assigned queues. */		/* for VF assigned queues. */
	if (q_no < oct->sriov_info.pf_srn) {		if (q_no < oct->sriov_info.pf_srn) {