Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e29db0e authored by Chris Mason's avatar Chris Mason Committed by Andy Grover
Browse files

RDS: Use a generation counter to avoid rds_send_xmit loop 



rds_send_xmit is required to loop around after it releases the lock
because someone else could done a trylock, found someone working on the
list and backed off.

But, once we drop our lock, it is possible that someone else does come
in and make progress on the list.  We should detect this and not loop
around if another process is actually working on the list.

This patch adds a generation counter that is bumped every time we
get the lock and do some send work.  If the retry notices someone else
has bumped the generation counter, it does not need to loop around and
continue working.

Signed-off-by: default avatarChris Mason <chris.mason@oracle.com>
Signed-off-by: default avatarAndy Grover <andy.grover@oracle.com>
parent acfcd4d4

net/rds/connection.c

+1 −0
Original line number Diff line number Diff line
@@ -147,6 +147,7 @@ static struct rds_connection *__rds_conn_create(__be32 laddr, __be32 faddr, 
	conn->c_next_tx_seq = 1;



	spin_lock_init(&conn->c_send_lock);

	atomic_set(&conn->c_send_generation, 1);

	INIT_LIST_HEAD(&conn->c_send_queue);

	INIT_LIST_HEAD(&conn->c_retrans);

net/rds/rds.h

+1 −0
Original line number Diff line number Diff line
@@ -92,6 +92,7 @@ struct rds_connection { 
	struct rds_cong_map	*c_fcong;



	spinlock_t		c_send_lock;	/* protect send ring */

	atomic_t		c_send_generation;

	struct rds_message	*c_xmit_rm;

	unsigned long		c_xmit_sg;

	unsigned int		c_xmit_hdr_off;

net/rds/send.c

+7 −4
Original line number Diff line number Diff line
@@ -112,6 +112,7 @@ int rds_send_xmit(struct rds_connection *conn) 
	unsigned int tmp;

	struct scatterlist *sg;

	int ret = 0;

	int gen = 0;

	LIST_HEAD(to_be_dropped);



restart:
@@ -134,6 +135,8 @@ int rds_send_xmit(struct rds_connection *conn) 
	if (conn->c_trans->xmit_prepare)

		conn->c_trans->xmit_prepare(conn);



	gen = atomic_inc_return(&conn->c_send_generation);



	/*

	 * spin trying to push headers and data down the connection until

	 * the connection doesn't make forward progress.
@@ -359,13 +362,13 @@ int rds_send_xmit(struct rds_connection *conn) 
	if (ret == 0) {

		/* A simple bit test would be way faster than taking the

		 * spin lock */

		spin_lock_irqsave(&conn->c_lock, flags);

		smp_mb();

		if (!list_empty(&conn->c_send_queue)) {

			rds_stats_inc(s_send_lock_queue_raced);

			spin_unlock_irqrestore(&conn->c_lock, flags);

			if (gen == atomic_read(&conn->c_send_generation)) {

				goto restart;

			}

		spin_unlock_irqrestore(&conn->c_lock, flags);

		}

	}

out:

	return ret;