Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9e14de10 authored by Chanwoo Choi's avatar Chanwoo Choi Committed by MyungJoo Ham
Browse files

PM / devfreq: Fix memory leak when fail to register device 



When the devfreq_add_device fails to register deivce, the memory
leak of devfreq instance happen. So, this patch fix the memory
leak issue. Before freeing the devfreq instance checks whether
devfreq instance is NULL or not because the device_unregister()
frees the devfreq instance when jumping to the 'err_init'.
It is to prevent the duplicate the kfee(devfreq).

Cc: stable@vger.kernel.org
Fixes: ac4b2811 ("PM / devfreq: fix duplicated kfree on devfreq pointer")
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: default avatarMyungJoo Ham <myungjoo.ham@samsung.com>
parent b9c69e04

drivers/devfreq/devfreq.c

+4 −1
Original line number Diff line number Diff line
@@ -564,7 +564,7 @@ struct devfreq *devfreq_add_device(struct device *dev, 
	err = device_register(&devfreq->dev);

	if (err) {

		mutex_unlock(&devfreq->lock);

		goto err_out;

		goto err_dev;

	}



	devfreq->trans_table =	devm_kzalloc(&devfreq->dev,
@@ -610,6 +610,9 @@ struct devfreq *devfreq_add_device(struct device *dev, 
	mutex_unlock(&devfreq_list_lock);



	device_unregister(&devfreq->dev);

err_dev:

	if (devfreq)

		kfree(devfreq);

err_out:

	return ERR_PTR(err);

}