Commit 9e01e2d5 authored Aug 02, 2017 by Stefan Agner Committed by Shawn Guo Aug 05, 2017

soc: imx: gpcv2: fix regulator deferred probe



If a regulator requests a deferred probe, the power domain gets
initialized twice. This leads to a list double add (without
list debugging the kernel hangs due to the double add later):

  WARNING: CPU: 0 PID: 19 at lib/list_debug.c:31 __list_add_valid+0xbc/0xc4
  list_add double add: new=c1229754, prev=c12383b4, next=c1229754.

Initialize the power domain after we get the regulator. Also do
not print an error in case the regulator defers probing.

Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Fixes: 03aa1262 ("soc: imx: Add GPCv2 power gating driver")
Signed-off-by: Stefan Agner <stefan@agner.ch>
Acked-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Tested-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>

parent 05969566

drivers/soc/imx/gpcv2.c

+8 −7

Original line number	Diff line number	Diff line
		@@ -200,15 +200,10 @@ static int imx7_pgc_domain_probe(struct platform_device *pdev)

		domain->dev = &pdev->dev;

		ret = pm_genpd_init(&domain->genpd, NULL, true);
		if (ret) {
		dev_err(domain->dev, "Failed to init power domain\n");
		return ret;
		}

		domain->regulator = devm_regulator_get_optional(domain->dev, "power");
		if (IS_ERR(domain->regulator)) {
		if (PTR_ERR(domain->regulator) != -ENODEV) {
		if (PTR_ERR(domain->regulator) != -EPROBE_DEFER)
		dev_err(domain->dev, "Failed to get domain's regulator\n");
		return PTR_ERR(domain->regulator);
		}
		@@ -217,6 +212,12 @@ static int imx7_pgc_domain_probe(struct platform_device *pdev)
		domain->voltage, domain->voltage);
		}

		ret = pm_genpd_init(&domain->genpd, NULL, true);
		if (ret) {
		dev_err(domain->dev, "Failed to init power domain\n");
		return ret;
		}

		ret = of_genpd_add_provider_simple(domain->dev->of_node,
		&domain->genpd);
		if (ret) {