Commit 9dfef3ad authored Jan 05, 2014 by Yuval Mintz Committed by David S. Miller Jan 05, 2014

bnx2x: fix AFEX memory overflow



There are 2 different (related) flows in the slowpath configuration
that utilize the same pointer and cast it to different structs;
This is obviously incorrect as the intended allocated memory is that
of the smaller struct, possibly causing the flow utilizing the larger
struct to corrupt other slowpath configuration.

Since both flows are exclusive, set the allocated memory to be a union
of both structs.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
Signed-off-by: Ariel Elior <ariele@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 5b622918

drivers/net/ethernet/broadcom/bnx2x/bnx2x.h

+4 −1

Original line number	Diff line number	Diff line
		@@ -1250,7 +1250,10 @@ struct bnx2x_slowpath {
		* Therefore, if they would have been defined in the same union,
		* data can get corrupted.
		*/
		struct afex_vif_list_ramrod_data func_afex_rdata;
		union {
		struct afex_vif_list_ramrod_data viflist_data;
		struct function_update_data func_update;
		} func_afex_rdata;

		/* used by dmae command executer */
		struct dmae_command dmae[MAX_DMAE_C];