Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9dbce044 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: wm_adsp: memory leak in wm_adsp_create_control() 



There are two return paths which don't kfree(name).

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent 6ab2b7b4

sound/soc/codecs/wm_adsp.c

+4 −2
Original line number Diff line number Diff line
@@ -836,7 +836,8 @@ static int wm_adsp_create_control(struct snd_soc_codec *codec, 
		region_name = "ZM";

		break;

	default:

		return -EINVAL;

		ret = -EINVAL;

		goto err_name;

	}



	snprintf(name, PAGE_SIZE, "DSP%d %s %x",
@@ -847,7 +848,7 @@ static int wm_adsp_create_control(struct snd_soc_codec *codec, 
		if (!strcmp(ctl->name, name)) {

			if (!ctl->enabled)

				ctl->enabled = 1;

			return 0;

			goto found;

		}

	}
@@ -887,6 +888,7 @@ static int wm_adsp_create_control(struct snd_soc_codec *codec, 
	INIT_WORK(&ctl_work->work, wm_adsp_ctl_work);

	schedule_work(&ctl_work->work);



found:

	kfree(name);



	return 0;