Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9da0aaf4 authored by Kyle Yan's avatar Kyle Yan Committed by Rishabh Bhatnagar
Browse files

firmware: Reword error messages when kernel is unable to find firmware 



The current error message printed when kernel fails to find the firmware
suggests that the entire operation has failed when the user helper may
still find the firmware. As we pass the return code back up, let the
calling driver determine if the entire operation has failed or not.

Change-Id: I5d8ce65e533e1925e98a49a0a88280549af75cb9
Signed-off-by: default avatarKyle Yan <kyan@codeaurora.org>
Signed-off-by: default avatarRishabh Bhatnagar <rishabhb@codeaurora.org>
parent f9723357

drivers/base/firmware_loader/main.c

+2 −2
Original line number Diff line number Diff line
@@ -578,8 +578,8 @@ _request_firmware(const struct firmware **firmware_p, const char *name, 
	ret = fw_get_filesystem_firmware(device, fw->priv);

	if (ret) {

		if (!(opt_flags & FW_OPT_NO_WARN))

			dev_warn(device,

				 "Direct firmware load for %s failed with error %d\n",

			dev_dbg(device,

				 "Firmware %s was not found in kernel paths. rc:%d\n",

				 name, ret);

		ret = firmware_fallback_sysfs(fw, name, device, opt_flags, ret);

	} else