Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d63487f authored by Alessio Igor Bogani's avatar Alessio Igor Bogani Committed by Rusty Russell
Browse files

module: Use binary search in lookup_symbol() 



The function is_exported() with its helper function lookup_symbol() are used to
verify if a provided symbol is effectively exported by the kernel or by the
modules. Now that both have their symbols sorted we can replace a linear search
with a binary search which provide a considerably speed-up.

This work was supported by a hardware donation from the CE Linux Forum.

Signed-off-by: default avatarAlessio Igor Bogani <abogani@kernel.org>
Acked-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 403ed278

kernel/module.c

+2 −5
Original line number Diff line number Diff line
@@ -2055,11 +2055,8 @@ static const struct kernel_symbol *lookup_symbol(const char *name, 
	const struct kernel_symbol *start,

	const struct kernel_symbol *stop)

{

	const struct kernel_symbol *ks = start;

	for (; ks < stop; ks++)

		if (strcmp(ks->name, name) == 0)

			return ks;

	return NULL;

	return bsearch(name, start, stop - start,

			sizeof(struct kernel_symbol), cmp_name);

}



static int is_exported(const char *name, unsigned long value,