Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9d35593b authored by Dexuan Cui's avatar Dexuan Cui Committed by Greg Kroah-Hartman
Browse files

vmbus: hvsock: add proper sync for vmbus_hvsock_device_unregister() 



Without the patch, vmbus_hvsock_device_unregister() can destroy the device
prematurely when close() is called, and can cause NULl dereferencing or
potential data loss (the last portion of the data stream may be dropped
prematurely).

Signed-off-by: default avatarDexuan Cui <decui@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 66b83a4c

drivers/hv/channel_mgmt.c

+4 −1
Original line number Diff line number Diff line
@@ -937,7 +937,10 @@ void vmbus_hvsock_device_unregister(struct vmbus_channel *channel) 
{

	BUG_ON(!is_hvsock_channel(channel));



	channel->rescind = true;

	/* We always get a rescind msg when a connection is closed. */

	while (!READ_ONCE(channel->probe_done) || !READ_ONCE(channel->rescind))

		msleep(1);



	vmbus_device_unregister(channel->device_obj);

}

EXPORT_SYMBOL_GPL(vmbus_hvsock_device_unregister);