Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9c2a4559 authored by Philipp Zabel's avatar Philipp Zabel Committed by Mauro Carvalho Chehab
Browse files

media: coda: do not reassign ctx->tiled_map_type in coda_s_fmt 



This smatch warning:

    coda/coda-common.c:706 coda_s_fmt() warn: missing break? reassigning 'ctx->tiled_map_type'

can be silenced by moving the ctx->tiled_map_type assignment into the
breakout condition. That way the field is not reassigned when falling
through to the next switch statement.

Signed-off-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 462e8ce0

drivers/media/platform/coda/coda-common.c

+3 −2
Original line number Diff line number Diff line
@@ -714,9 +714,10 @@ static int coda_s_fmt(struct coda_ctx *ctx, struct v4l2_format *f, 
		ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP;

		break;

	case V4L2_PIX_FMT_NV12:

		if (!disable_tiling) {

			ctx->tiled_map_type = GDI_TILED_FRAME_MB_RASTER_MAP;

		if (!disable_tiling)

			break;

		}

		/* else fall through */

	case V4L2_PIX_FMT_YUV420:

	case V4L2_PIX_FMT_YVU420: