Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9bc2dd7e authored by Markus Elfring's avatar Markus Elfring Committed by Mauro Carvalho Chehab
Browse files

[media] DVB-frontends: Deletion of unnecessary checks before the function call "release_firmware" 



GIT_AUTHOR_DATE=1416472432
The release_firmware() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
parent d442b15f

drivers/media/dvb-frontends/drx39xyj/drxj.c

+1 −2
Original line number Diff line number Diff line
@@ -12255,7 +12255,6 @@ static void drx39xxj_release(struct dvb_frontend *fe) 
	kfree(demod->my_ext_attr);

	kfree(demod->my_common_attr);

	kfree(demod->my_i2c_dev_addr);

	if (demod->firmware)

	release_firmware(demod->firmware);

	kfree(demod);

	kfree(state);

drivers/media/dvb-frontends/drxk_hard.c

+1 −2
Original line number Diff line number Diff line
@@ -6310,7 +6310,6 @@ static void drxk_release(struct dvb_frontend *fe) 
	struct drxk_state *state = fe->demodulator_priv;



	dprintk(1, "\n");

	if (state->fw)

	release_firmware(state->fw);



	kfree(state);

drivers/media/dvb-frontends/m88ds3103.c

+1 −2
Original line number Diff line number Diff line
@@ -687,7 +687,6 @@ static int m88ds3103_init(struct dvb_frontend *fe) 


	return 0;

err:

	if (fw)

	release_firmware(fw);



	dev_dbg(&priv->i2c->dev, "%s: failed=%d\n", __func__, ret);

drivers/media/dvb-frontends/si2168.c

+1 −2
Original line number Diff line number Diff line
@@ -507,7 +507,6 @@ static int si2168_init(struct dvb_frontend *fe) 


	return 0;

err:

	if (fw)

	release_firmware(fw);



	dev_dbg(&s->client->dev, "failed=%d\n", ret);