Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ba89334 authored by Ian Wienand's avatar Ian Wienand Committed by Tony Luck
Browse files

[IA64] SKI Simulator boot 



Sorry I didn't notice earlier, but that BUG_ON triggers for me on the
simulator.  AFAICS the mask for itv is set in cpu_init(), which comes
after sal_init().  Consequently on the simulator the itv still has its
start value of zero.  I've probably missed something, but I wonder why
at this stage of the boot you even need to save and restore the itv?

Signed-Off-By: default avatarIan Wienand <ianw@gelato.unsw.edu.au>
Signed-off-by: default avatarTony Luck <tony.luck@intel.com>
parent f640f94e

arch/ia64/kernel/sal.c

+1 −5
Original line number Diff line number Diff line
@@ -227,7 +227,7 @@ static int sal_cache_flush_drops_interrupts; 
static void __init

check_sal_cache_flush (void)

{

	unsigned long flags, itv;

	unsigned long flags;

	int cpu;

	u64 vector;
@@ -238,9 +238,6 @@ check_sal_cache_flush (void) 
	 * Schedule a timer interrupt, wait until it's reported, and see if

	 * SAL_CACHE_FLUSH drops it.

	 */

	itv = ia64_get_itv();

	BUG_ON((itv & (1 << 16)) == 0);



	ia64_set_itv(IA64_TIMER_VECTOR);

	ia64_set_itm(ia64_get_itc() + 1000);
@@ -260,7 +257,6 @@ check_sal_cache_flush (void) 
		ia64_eoi();

	}



	ia64_set_itv(itv);

	local_irq_restore(flags);

	put_cpu();

}