Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b651900 authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Greg Kroah-Hartman
Browse files

tty/vt/keyboard: use memdup_user(). 



Use memdup_user to duplicate a memory region from user-space to
kernel-space, instead of open coding using kmalloc & copy_from_user.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Reviewed-by: default avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a7cfaf16

drivers/tty/vt/keyboard.c

+4 −10
Original line number Diff line number Diff line
@@ -1745,16 +1745,10 @@ int vt_do_diacrit(unsigned int cmd, void __user *udp, int perm) 
			return -EINVAL;



		if (ct) {

			buf = kmalloc(ct * sizeof(struct kbdiacruc),

								GFP_KERNEL);

			if (buf == NULL)

				return -ENOMEM;



			if (copy_from_user(buf, a->kbdiacruc,

					ct * sizeof(struct kbdiacruc))) {

				kfree(buf);

				return -EFAULT;

			}

			buf = memdup_user(a->kbdiacruc,

					  ct * sizeof(struct kbdiacruc));

			if (IS_ERR(buf))

				return PTR_ERR(buf);

		} 

		spin_lock_irqsave(&kbd_event_lock, flags);

		if (ct)