Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b200b02 authored by Jesper Juhl's avatar Jesper Juhl Committed by David S. Miller
Browse files

[SLIP]: Simplify sl_free_bufs() 



We can avoid assignments to the local variable 'tmp' and 
actually get rid of tmp alltogether in sl_free_bufs(). This patch does 
that.  This is safe since both kfree() and slhc_free() handles NULL 
pointers gracefully.

Signed-off-by: default avatarJesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d675c989

drivers/net/slip.c

+4 −10
Original line number Diff line number Diff line
@@ -198,18 +198,12 @@ sl_alloc_bufs(struct slip *sl, int mtu) 
static void

sl_free_bufs(struct slip *sl)

{

	void * tmp;



	/* Free all SLIP frame buffers. */

	tmp = xchg(&sl->rbuff, NULL);

	kfree(tmp);

	tmp = xchg(&sl->xbuff, NULL);

	kfree(tmp);

	kfree(xchg(&sl->rbuff, NULL));

	kfree(xchg(&sl->xbuff, NULL));

#ifdef SL_INCLUDE_CSLIP

	tmp = xchg(&sl->cbuff, NULL);

	kfree(tmp);

	if ((tmp = xchg(&sl->slcomp, NULL)) != NULL)

		slhc_free(tmp);

	kfree(xchg(&sl->cbuff, NULL));

	slhc_free(xchg(&sl->slcomp, NULL));

#endif

}