Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b171e0c authored by Jan Kara's avatar Jan Kara Committed by Al Viro
Browse files

ocfs2: fix possible use-after-free with AIO 



Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Acked-by: default avatarJeff Moyer <jmoyer@redhat.com>
Acked-by: default avatarJoel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 30b9c9e6

fs/ocfs2/aops.c

+1 −1
Original line number Diff line number Diff line
@@ -593,9 +593,9 @@ static void ocfs2_dio_end_io(struct kiocb *iocb, 
	level = ocfs2_iocb_rw_locked_level(iocb);

	ocfs2_rw_unlock(inode, level);



	inode_dio_done(inode);

	if (is_async)

		aio_complete(iocb, ret, 0);

	inode_dio_done(inode);

}



/*