Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9ab2323c authored by Xin Long's avatar Xin Long Committed by David S. Miller
Browse files

sctp: remove the left unnecessary check for chunk in sctp_renege_events 



Commit fb234035 ("sctp: remove the useless check in
sctp_renege_events") forgot to remove another check for
chunk in sctp_renege_events.

Dan found this when doing a static check.

This patch is to remove that check, and also to merge
two checks into one 'if statement'.

Fixes: fb234035 ("sctp: remove the useless check in sctp_renege_events")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Acked-by: default avatarMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a16b8d0c

net/sctp/stream_interleave.c

+2 −3
Original line number Diff line number Diff line
@@ -968,8 +968,7 @@ static void sctp_renege_events(struct sctp_ulpq *ulpq, struct sctp_chunk *chunk, 
						       needed);

	}



	if (chunk && freed >= needed)

		if (sctp_ulpevent_idata(ulpq, chunk, gfp) <= 0)

	if (freed >= needed && sctp_ulpevent_idata(ulpq, chunk, gfp) <= 0)

		sctp_intl_start_pd(ulpq, gfp);



	sk_mem_reclaim(asoc->base.sk);