Commit 9a6e91d0 authored Aug 19, 2017 by Christophe Jaillet Committed by Rafael J. Wysocki Aug 25, 2017

cpufreq: ti: Fix 'of_node_put' being called twice in error handling path



If 'dev_pm_opp_set_supported_hw()' fails, 'opp_data->opp_node' refcount
will be decremented 2 times.
One, just a few lines above, and another one in the error handling path.

Fix it by simply moving the 'of_node_put' call of the normal path.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent d79d148b

drivers/cpufreq/ti-cpufreq.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -245,8 +245,6 @@ static int ti_cpufreq_init(void)
		if (ret)
		goto fail_put_node;

		of_node_put(opp_data->opp_node);

		ret = PTR_ERR_OR_ZERO(dev_pm_opp_set_supported_hw(opp_data->cpu_dev,
		version, VERSION_COUNT));
		if (ret) {
		@@ -255,6 +253,8 @@ static int ti_cpufreq_init(void)
		goto fail_put_node;
		}

		of_node_put(opp_data->opp_node);

		register_cpufreq_dt:
		platform_device_register_simple("cpufreq-dt", -1, NULL, 0);