Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9a62ca40 authored by Robin Getz's avatar Robin Getz Committed by Bryan Wu
Browse files

[Blackfin] arch: fix bug - when we crash, current is not valid 



Sometimes when we crash, current is not valid, (has been written
over), so the existing code causes a invalid read during exception
context - which is a unrecoverable double fault. This fixes this.

Signed-off-by: default avatarRobin Getz <rgetz@blackfin.uclinux.org>
Signed-off-by: default avatarBryan Wu <cooloney@kernel.org>
parent 81d9c7f2

arch/blackfin/kernel/traps.c

+23 −14
Original line number Diff line number Diff line
@@ -655,11 +655,18 @@ void dump_bfin_process(struct pt_regs *fp) 
	else if (context & 0x8000)

		printk(KERN_NOTICE "Kernel process context\n");



	if (current->pid && current->mm) {

	/* Because we are crashing, and pointers could be bad, we check things

	 * pretty closely before we use them

	 */

	if (!((unsigned long)current & 0x3) && current->pid) {

		printk(KERN_NOTICE "CURRENT PROCESS:\n");

		if (current->comm >= (char *)FIXED_CODE_START)

			printk(KERN_NOTICE "COMM=%s PID=%d\n",

				current->comm, current->pid);

		else

			printk(KERN_NOTICE "COMM= invalid\n");



		if (!((unsigned long)current->mm & 0x3) && (unsigned long)current->mm >= FIXED_CODE_START)

			printk(KERN_NOTICE  "TEXT = 0x%p-0x%p        DATA = 0x%p-0x%p\n"

				KERN_NOTICE " BSS = 0x%p-0x%p  USER-STACK = 0x%p\n"

				KERN_NOTICE "\n",
@@ -670,6 +677,8 @@ void dump_bfin_process(struct pt_regs *fp) 
				(void *)current->mm->end_data,

				(void *)current->mm->brk,

				(void *)current->mm->start_stack);

		else

			printk(KERN_NOTICE "invalid mm\n");

	} else

		printk(KERN_NOTICE "\n" KERN_NOTICE

		     "No Valid process in current context\n");