Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9994c977 authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by Greg Kroah-Hartman
Browse files

staging: rtl8723au: os_dep: usb_intf: Remove unused functions 



Removes some functions that are not used anywhere:
rtw_hw_resume23a() rtw_hw_suspend23a()

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 05f35980

drivers/staging/rtl8723au/include/osdep_intf.h

+0 −3
Original line number Diff line number Diff line
@@ -19,9 +19,6 @@ 
#include <osdep_service.h>

#include <drv_types.h>



int rtw_hw_suspend23a(struct rtw_adapter *padapter);

int rtw_hw_resume23a(struct rtw_adapter *padapter);



int rtw_init_drv_sw23a(struct rtw_adapter *padapter);

int rtw_free_drv_sw23a(struct rtw_adapter *padapter);

int rtw_reset_drv_sw23a(struct rtw_adapter *padapter);

drivers/staging/rtl8723au/os_dep/usb_intf.c

+0 −98
Original line number Diff line number Diff line
@@ -267,104 +267,6 @@ static void rtw_dev_unload(struct rtw_adapter *padapter) 
	RT_TRACE(_module_hci_intfs_c_, _drv_err_, ("-rtw_dev_unload\n"));

}



int rtw_hw_suspend23a(struct rtw_adapter *padapter)

{

	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;

	struct net_device *pnetdev = padapter->pnetdev;

	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;



	if ((!padapter->bup) || (padapter->bDriverStopped) ||

	    (padapter->bSurpriseRemoved)) {

		DBG_8723A("padapter->bup =%d bDriverStopped =%d bSurpriseRemoved = %d\n",

			  padapter->bup, padapter->bDriverStopped,

			  padapter->bSurpriseRemoved);

		goto error_exit;

	}



	if (padapter) { /* system suspend */

		LeaveAllPowerSaveMode23a(padapter);



		DBG_8723A("==> rtw_hw_suspend23a\n");

		down(&pwrpriv->lock);

		pwrpriv->bips_processing = true;

		/* padapter->net_closed = true; */

		/* s1. */

		if (pnetdev) {

			netif_carrier_off(pnetdev);

			netif_tx_stop_all_queues(pnetdev);

		}



		/* s2. */

		rtw_disassoc_cmd23a(padapter, 500, false);



		/* s2-2.  indicate disconnect to os */

		/* rtw_indicate_disconnect23a(padapter); */

		if (check_fwstate(pmlmepriv, _FW_LINKED)) {

			_clr_fwstate_(pmlmepriv, _FW_LINKED);



			rtw_os_indicate_disconnect23a(padapter);



			/* donnot enqueue cmd */

			rtw_lps_ctrl_wk_cmd23a(padapter,

					       LPS_CTRL_DISCONNECT, 0);

		}

		/* s2-3. */

		rtw_free_assoc_resources23a(padapter, 1);



		/* s2-4. */

		rtw_free_network_queue23a(padapter);

		rtw_ips_dev_unload23a(padapter);

		pwrpriv->rf_pwrstate = rf_off;

		pwrpriv->bips_processing = false;

		up(&pwrpriv->lock);

	} else {

		goto error_exit;

	}

	return 0;

error_exit:

	DBG_8723A("%s, failed\n", __func__);

	return -1;

}



int rtw_hw_resume23a(struct rtw_adapter *padapter)

{

	struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv;

	struct net_device *pnetdev = padapter->pnetdev;



	if (padapter) { /* system resume */

		DBG_8723A("==> rtw_hw_resume23a\n");

		down(&pwrpriv->lock);

		pwrpriv->bips_processing = true;

		rtw_reset_drv_sw23a(padapter);



		if (pm_netdev_open23a(pnetdev, false)) {

			up(&pwrpriv->lock);

			goto error_exit;

		}



		netif_device_attach(pnetdev);

		netif_carrier_on(pnetdev);



		if (!rtw_netif_queue_stopped(pnetdev))

			netif_tx_start_all_queues(pnetdev);

		else

			netif_tx_wake_all_queues(pnetdev);



		pwrpriv->bkeepfwalive = false;



		pwrpriv->rf_pwrstate = rf_on;

		pwrpriv->bips_processing = false;



		up(&pwrpriv->lock);

	} else {

		goto error_exit;

	}

	return 0;

error_exit:

	DBG_8723A("%s, Open net dev failed\n", __func__);

	return -1;

}



static int rtw_suspend(struct usb_interface *pusb_intf, pm_message_t message)

{

	struct dvobj_priv *dvobj = usb_get_intfdata(pusb_intf);