Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 98b16a09 authored by Javier Martinez Canillas's avatar Javier Martinez Canillas Committed by Guenter Roeck
Browse files

hwmon: (max31785) Add OF device ID table 



The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

Before this patch:

$ modinfo drivers/hwmon/pmbus/max31785.ko | grep alias
alias:          i2c:max31785a
alias:          i2c:max31785

After this patch:

$ modinfo drivers/hwmon/pmbus/max31785.ko | grep alias
alias:          i2c:max31785a
alias:          i2c:max31785
alias:          of:N*T*Cmaxim,max31785aC*
alias:          of:N*T*Cmaxim,max31785a
alias:          of:N*T*Cmaxim,max31785C*
alias:          of:N*T*Cmaxim,max31785

Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 5d389b12

drivers/hwmon/pmbus/max31785.c

+9 −0
Original line number Diff line number Diff line
@@ -383,9 +383,18 @@ static const struct i2c_device_id max31785_id[] = { 


MODULE_DEVICE_TABLE(i2c, max31785_id);



static const struct of_device_id max31785_of_match[] = {

	{ .compatible = "maxim,max31785" },

	{ .compatible = "maxim,max31785a" },

	{ },

};



MODULE_DEVICE_TABLE(of, max31785_of_match);



static struct i2c_driver max31785_driver = {

	.driver = {

		.name = "max31785",

		.of_match_table = max31785_of_match,

	},

	.probe = max31785_probe,

	.remove = pmbus_do_remove,