Commit 9841d61d authored Jan 08, 2006 by Dave Jones Committed by Linus Torvalds Jan 08, 2006

[PATCH] Add tainting for proprietary helper modules



Kernels that have had Windows drivers loaded into them are undebuggable.
I've wasted a number of hours chasing bugs filed in Fedora bugzilla only to
find out much later that the user had used such 'helpers', and their
problems were unreproducable without them loaded.

Acked-by: Arjan van de Ven <arjan@infradead.org>
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f867bac6

kernel/module.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1715,6 +1715,11 @@ static struct module load_module(void __user umod,
		/* Set up license info based on the info section */
		set_license(mod, get_modinfo(sechdrs, infoindex, "license"));

		if (strcmp(mod->name, "ndiswrapper") == 0)
		add_taint(TAINT_PROPRIETARY_MODULE);
		if (strcmp(mod->name, "driverloader") == 0)
		add_taint(TAINT_PROPRIETARY_MODULE);

		#ifdef CONFIG_MODULE_UNLOAD
		/* Set up MODINFO_ATTR fields */
		setup_modinfo(mod, sechdrs, infoindex);