Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 96bedb63 authored by John Youn's avatar John Youn Committed by Felipe Balbi
Browse files

usb: dwc3: Endianness issue on dwc3_log_ctrl 



Sparse complains even though it looks ok. Probably it cannot detect that
the wValue, wIndex, and wLength are declared __le16 due to the macro
magic.

Redeclare them as CPU endianness and make the conversion on assignment.

Signed-off-by: default avatarJohn Youn <johnyoun@synopsys.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent d07fa665

drivers/usb/dwc3/trace.h

+8 −8
Original line number Diff line number Diff line
@@ -86,21 +86,21 @@ DECLARE_EVENT_CLASS(dwc3_log_ctrl, 
	TP_STRUCT__entry(

		__field(__u8, bRequestType)

		__field(__u8, bRequest)

		__field(__le16, wValue)

		__field(__le16, wIndex)

		__field(__le16, wLength)

		__field(__u16, wValue)

		__field(__u16, wIndex)

		__field(__u16, wLength)

	),

	TP_fast_assign(

		__entry->bRequestType = ctrl->bRequestType;

		__entry->bRequest = ctrl->bRequest;

		__entry->wValue = ctrl->wValue;

		__entry->wIndex = ctrl->wIndex;

		__entry->wLength = ctrl->wLength;

		__entry->wValue = le16_to_cpu(ctrl->wValue);

		__entry->wIndex = le16_to_cpu(ctrl->wIndex);

		__entry->wLength = le16_to_cpu(ctrl->wLength);

	),

	TP_printk("bRequestType %02x bRequest %02x wValue %04x wIndex %04x wLength %d",

		__entry->bRequestType, __entry->bRequest,

		le16_to_cpu(__entry->wValue), le16_to_cpu(__entry->wIndex),

		le16_to_cpu(__entry->wLength)

		__entry->wValue, __entry->wIndex,

		__entry->wLength

	)

);