Commit 966301a2 authored Jan 22, 2015 by Xunlei Pang Committed by John Stultz Jan 23, 2015

rtc: Remove redundant rtc_valid_tm() from rtc_hctosys()



rtc_read_time() has already judged valid tm by rtc_valid_tm(),
so just remove it.

Cc: pang.xunlei <pang.xunlei@linaro.org>
Cc: Arnd Bergmann <arnd.bergmann@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Xunlei Pang <pang.xunlei@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>

parent a6d6e1c8

drivers/rtc/hctosys.c

+0 −8

Original line number	Diff line number	Diff line
		@@ -45,13 +45,6 @@ static int __init rtc_hctosys(void)

		}

		err = rtc_valid_tm(&tm);
		if (err) {
		dev_err(rtc->dev.parent,
		"hctosys: invalid date/time\n");
		goto err_invalid;
		}

		tv64.tv_sec = rtc_tm_to_time64(&tm);

		err = do_settimeofday64(&tv64);
		@@ -63,7 +56,6 @@ static int __init rtc_hctosys(void)
		tm.tm_hour, tm.tm_min, tm.tm_sec,
		(long long) tv64.tv_sec);

		err_invalid:
		err_read:
		rtc_class_close(rtc);