Commit 960b8466 authored Jul 07, 2005 by Ivan Kokshaysky Committed by Linus Torvalds Jul 06, 2005

[PATCH] yet another fix for setup-bus.c/x86 merge



There is a slight disagreement between setup-bus.c code and traditional
x86 PCI setup wrt which recourses are invalid vs resources that are free
for further allocations.

In particular, in the setup-bus.c, if we failed to allocate some resource,
we nullify "start" and "flags" fields, but *not* the "end" one.

But x86 pcibios_enable_resources() does the following check:

	if (!r->start && r->end) {
		printk(KERN_ERR "PCI: Device %s not available because of resource collisions\n", pci_name(dev));
		return -EINVAL;

which means that the device owning the offending resource cannot be
enabled.

In particular, this breaks cardbus behind the normal decode p2p bridge -
the cardbus code from setup-bus.c requests rather large IO and MEM
windows, and if it fails, the socket is completely unavailable.  Which
is wrong, as the yenta code is capable to allocate smaller windows.

Signed-off-by: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 10717741

drivers/pci/setup-bus.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -74,6 +74,7 @@ pbus_assign_resources_sorted(struct pci_bus *bus)
		idx = res - &list->dev->resource[0];
		if (pci_assign_resource(list->dev, idx)) {
		res->start = 0;
		res->end = 0;
		res->flags = 0;
		}
		tmp = list;