Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 95f1acd1 authored by Dmitry Antipov's avatar Dmitry Antipov Committed by Greg Kroah-Hartman
Browse files

wifi: ath9k: fix LNA selection in ath_ant_try_scan() 



[ Upstream commit d6b27eb997ef9a2aa51633b3111bc4a04748e6d3 ]

In 'ath_ant_try_scan()', (most likely) the 2nd LNA's signal
strength should be used in comparison against RSSI when
selecting first LNA as the main one. Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarDmitry Antipov <dmantipov@yandex.ru>
Acked-by: default avatarToke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: default avatarKalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/20231211172502.25202-1-dmantipov@yandex.ru


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 5fd82952

drivers/net/wireless/ath/ath9k/antenna.c

+1 −1
Original line number Diff line number Diff line
@@ -643,7 +643,7 @@ static void ath_ant_try_scan(struct ath_ant_comb *antcomb, 
				conf->main_lna_conf = ATH_ANT_DIV_COMB_LNA1;

				conf->alt_lna_conf = ATH_ANT_DIV_COMB_LNA1_PLUS_LNA2;

			} else if (antcomb->rssi_sub >

				   antcomb->rssi_lna1) {

				   antcomb->rssi_lna2) {

				/* set to A-B */

				conf->main_lna_conf = ATH_ANT_DIV_COMB_LNA1;

				conf->alt_lna_conf = ATH_ANT_DIV_COMB_LNA1_MINUS_LNA2;