Commit 95a0e656 authored Jun 11, 2018 by Christophe JAILLET Committed by Greg Kroah-Hartman Jun 28, 2018

serial: pxa: Fix an error handling path in 'serial_pxa_probe()'



If port.line is out of range, we still need to release some resources, or
we will leak them.

Fixes: afc7851f ("serial: pxa: Fix out-of-bounds access through serial port index")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 4cf9a888

drivers/tty/serial/pxa.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -887,7 +887,8 @@ static int serial_pxa_probe(struct platform_device *dev)
		goto err_clk;
		if (sport->port.line >= ARRAY_SIZE(serial_pxa_ports)) {
		dev_err(&dev->dev, "serial%d out of range\n", sport->port.line);
		return -EINVAL;
		ret = -EINVAL;
		goto err_clk;
		}
		snprintf(sport->name, PXA_NAME_LEN - 1, "UART%d", sport->port.line + 1);