Commit 957d6bf6 authored Jun 04, 2013 by Joe Perches Committed by Geert Uytterhoeven Jun 24, 2013

swim: Release memory region after incorrect return/goto



The code uses

	return foo;
	goto err_type;

when instead the form should have been

	ret = foo;
	goto err_type;

Here this causes a useful release_mem_region to be skipped.

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Laurent Vivier <Laurent@Vivier.EU>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

parent 378f7ca6

drivers/block/swim.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -893,7 +893,7 @@ static int swim_probe(struct platform_device *dev)

		swim_base = ioremap(res->start, resource_size(res));
		if (!swim_base) {
		return -ENOMEM;
		ret = -ENOMEM;
		goto out_release_io;
		}