Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 95523475 authored by Paul Wise's avatar Paul Wise Committed by OGAWA Hirofumi
Browse files

vfat: change the default from shortname=lower to shortname=mixed 



Because, with "shortname=lower", copying one FAT filesystem tree to
another FAT filesystem tree using Linux results in semantically
different filesystems. (E.g.: Filenames which were once "all
uppercase" are now "all lowercase").

So, this changes the default of "shortname=lower" to "shortname=mixed".

Signed-off-by: default avatarPaul Wise <pabs3@bonedaddy.net>
[change fat_show_options()]
Signed-off-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
parent 67638e40

Documentation/filesystems/vfat.txt

+1 −1
Original line number Diff line number Diff line
@@ -102,7 +102,7 @@ shortname=lower|win95|winnt|mixed 
		 winnt: emulate the Windows NT rule for display/create.

		 mixed: emulate the Windows NT rule for display,

			emulate the Windows 95 rule for create.

		 Default setting is `lower'.

		 Default setting is `mixed'.



tz=UTC        -- Interpret timestamps as UTC rather than local time.

                 This option disables the conversion of timestamps

fs/fat/inode.c

+2 −2
Original line number Diff line number Diff line
@@ -820,7 +820,7 @@ static int fat_show_options(struct seq_file *m, struct vfsmount *mnt) 
			seq_puts(m, ",shortname=mixed");

			break;

		case VFAT_SFN_DISPLAY_LOWER | VFAT_SFN_CREATE_WIN95:

			/* seq_puts(m, ",shortname=lower"); */

			seq_puts(m, ",shortname=lower");

			break;

		default:

			seq_puts(m, ",shortname=unknown");
@@ -971,7 +971,7 @@ static int parse_options(char *options, int is_vfat, int silent, int *debug, 
	opts->codepage = fat_default_codepage;

	opts->iocharset = fat_default_iocharset;

	if (is_vfat) {

		opts->shortname = VFAT_SFN_DISPLAY_LOWER|VFAT_SFN_CREATE_WIN95;

		opts->shortname = VFAT_SFN_DISPLAY_WINNT|VFAT_SFN_CREATE_WIN95;

		opts->rodir = 0;

	} else {

		opts->shortname = 0;