Commit 950aff53 authored Jun 17, 2010 by Ralph Campbell Committed by Roland Dreier Jul 06, 2010

IB/qib: Completion queue callback needs to be single threaded



Workqueues aren't exactly equivalent to tasklets since the callback
function may be called from multiple CPUs before the callback returns.
This causes completion notification callbacks to have MT bugs since
they weren't expecting this behavior. The fix is to use a single
threaded work queue.

Signed-off-by: Ralph Campbell <ralph.campbell@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent 7c7a416e

drivers/infiniband/hw/qib/qib_init.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1059,7 +1059,7 @@ static int __init qlogic_ib_init(void)
	goto bail_dev;		goto bail_dev;
	}		}

	qib_cq_wq = create_workqueue("qib_cq");		qib_cq_wq = create_singlethread_workqueue("qib_cq");
	if (!qib_cq_wq) {		if (!qib_cq_wq) {
	ret = -ENOMEM;		ret = -ENOMEM;
	goto bail_wq;		goto bail_wq;