Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 93bbaab4 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Reject unicast packet with zero/mcast dst address 



An unicast batman-adv packet cannot be transmitted to a multicast or zero
mac address. So reject incoming packets which still have these classes of
addresses as destination mac address in the outer ethernet header.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent 92eef520

net/batman-adv/routing.c

+4 −4
Original line number Diff line number Diff line
@@ -364,8 +364,8 @@ int batadv_recv_icmp_packet(struct sk_buff *skb, 


	ethhdr = eth_hdr(skb);



	/* packet with unicast indication but broadcast recipient */

	if (is_broadcast_ether_addr(ethhdr->h_dest))

	/* packet with unicast indication but non-unicast recipient */

	if (!is_valid_ether_addr(ethhdr->h_dest))

		goto free_skb;



	/* packet with broadcast/multicast sender address */
@@ -462,8 +462,8 @@ static int batadv_check_unicast_packet(struct batadv_priv *bat_priv, 


	ethhdr = eth_hdr(skb);



	/* packet with unicast indication but broadcast recipient */

	if (is_broadcast_ether_addr(ethhdr->h_dest))

	/* packet with unicast indication but non-unicast recipient */

	if (!is_valid_ether_addr(ethhdr->h_dest))

		return -EBADR;



	/* packet with broadcast/multicast sender address */