Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9382c06e authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: comedi: pcl730: fix some bitwise vs logical AND bugs 



These conditions are never true because they use bitwise AND instead of
logical ands.

Fixes: b3ff824a ('staging: comedi: drivers: use comedi_dio_update_state() for complex cases')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c16975a0

drivers/staging/comedi/drivers/pcl730.c

+3 −3
Original line number Diff line number Diff line
@@ -173,11 +173,11 @@ static int pcl730_do_insn_bits(struct comedi_device *dev, 
	if (mask) {

		if (mask & 0x00ff)

			outb(s->state & 0xff, dev->iobase + reg);

		if ((mask & 0xff00) & (s->n_chan > 8))

		if ((mask & 0xff00) && (s->n_chan > 8))

			outb((s->state >> 8) & 0xff, dev->iobase + reg + 1);

		if ((mask & 0xff0000) & (s->n_chan > 16))

		if ((mask & 0xff0000) && (s->n_chan > 16))

			outb((s->state >> 16) & 0xff, dev->iobase + reg + 2);

		if ((mask & 0xff000000) & (s->n_chan > 24))

		if ((mask & 0xff000000) && (s->n_chan > 24))

			outb((s->state >> 24) & 0xff, dev->iobase + reg + 3);

	}