Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 92792e48 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Ohad Ben-Cohen
Browse files

remoteproc: avoid stack overflow in debugfs file



Recent gcc versions warn about reading from a negative offset of
an on-stack array:

drivers/remoteproc/remoteproc_debugfs.c: In function 'rproc_recovery_write':
drivers/remoteproc/remoteproc_debugfs.c:167:9: warning: 'buf[4294967295u]' may be used uninitialized in this function [-Wmaybe-uninitialized]

I don't see anything in sys_write() that prevents us from
being called with a zero 'count' argument, so we should
add an extra check in rproc_recovery_write() to prevent the
access and avoid the warning.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: 2e37abb8 ("remoteproc: create a 'recovery' debugfs entry")
Signed-off-by: default avatarOhad Ben-Cohen <ohad@wizery.com>
parent 1ec21837
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment