Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 926e689c authored by Mohammed Siddiq's avatar Mohammed Siddiq
Browse files

cnss2: Fix KW issues for pointer check and variable init 



Fix KW issues by adding code for pci_priv NULL check before
deference and initialize cnss_reason for MHI_CB_BOOTUP_TIMEOUT
case.

Change-Id: Iab421c62f7cc346b36c4e9ba77403eb5e1923b5a
Signed-off-by: default avatarMohammed Siddiq <msiddiq@codeaurora.org>
parent 2544bae0

drivers/net/wireless/cnss2/pci.c

+3 −1
Original line number Diff line number Diff line
@@ -4483,11 +4483,12 @@ static void cnss_dev_rddm_timeout_hdlr(struct timer_list *t) 
{

	struct cnss_pci_data *pci_priv =

		from_timer(pci_priv, t, dev_rddm_timer);

	struct mhi_controller *mhi_ctrl = pci_priv->mhi_ctrl;

	struct mhi_controller *mhi_ctrl;



	if (!pci_priv)

		return;



	mhi_ctrl = pci_priv->mhi_ctrl;

	cnss_fatal_err("Timeout waiting for RDDM notification\n");



	if (mhi_get_exec_env(mhi_ctrl) == MHI_EE_PBL)
@@ -4565,6 +4566,7 @@ static void cnss_mhi_notify_status(struct mhi_controller *mhi_ctrl, void *priv, 
			cnss_pci_dump_bl_sram_mem(pci_priv);

			cnss_pci_dump_mhi_reg(pci_priv);

		}

		cnss_reason = CNSS_REASON_TIMEOUT;

		break;

	default:

		cnss_pr_err("Unsupported MHI status cb reason: %d\n", reason);