Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 92680bc8 authored by Sergey Shtylyov's avatar Sergey Shtylyov Committed by Greg Kroah-Hartman
Browse files

i2c: s3c2410: fix IRQ check 



[ Upstream commit d6840a5e370b7ea4fde16ce2caf431bcc87f9a75 ]

Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful).  Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...

Fixes: e0d1ec97 ("i2c-s3c2410: Change IRQ to be plain integer.")
Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e4491423

drivers/i2c/busses/i2c-s3c2410.c

+1 −1
Original line number Diff line number Diff line
@@ -1179,7 +1179,7 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) 
	 */

	if (!(i2c->quirks & QUIRK_POLL)) {

		i2c->irq = ret = platform_get_irq(pdev, 0);

		if (ret <= 0) {

		if (ret < 0) {

			dev_err(&pdev->dev, "cannot find IRQ\n");

			clk_unprepare(i2c->clk);

			return ret;