Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91d1ae47 authored by Kalderon, Michal's avatar Kalderon, Michal Committed by David S. Miller
Browse files

qed: Fix printk option passed when printing ipv6 addresses 



The option "h" (host order ) exists for ipv4 only.
Remove the h when printing ipv6 addresses.

Lead to the following smatch warning:

drivers/net/ethernet/qlogic/qed/qed_iwarp.c:585 qed_iwarp_print_tcp_ramrod()
warn: '%pI6' can only be followed by c
drivers/net/ethernet/qlogic/qed/qed_iwarp.c:1521 qed_iwarp_print_cm_info()
warn: '%pI6' can only be followed by c

Fixes commit 456a5849 ("qed: iWARP CM add passive side connect")

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMichal Kalderon <Michal.Kalderon@cavium.com>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5e34fa23

drivers/net/ethernet/qlogic/qed/qed_iwarp.c

+3 −3
Original line number Diff line number Diff line
@@ -575,7 +575,7 @@ qed_iwarp_print_tcp_ramrod(struct qed_hwfn *p_hwfn, 


	if (p_tcp_ramrod->tcp.ip_version == TCP_IPV4) {

		DP_VERBOSE(p_hwfn, QED_MSG_RDMA,

			   "local_ip=%pI4h:%x, remote_ip=%pI4h%x, vlan=%x\n",

			   "local_ip=%pI4h:%x, remote_ip=%pI4h:%x, vlan=%x\n",

			   p_tcp_ramrod->tcp.local_ip,

			   p_tcp_ramrod->tcp.local_port,

			   p_tcp_ramrod->tcp.remote_ip,
@@ -583,7 +583,7 @@ qed_iwarp_print_tcp_ramrod(struct qed_hwfn *p_hwfn, 
			   p_tcp_ramrod->tcp.vlan_id);

	} else {

		DP_VERBOSE(p_hwfn, QED_MSG_RDMA,

			   "local_ip=%pI6h:%x, remote_ip=%pI6h:%x, vlan=%x\n",

			   "local_ip=%pI6:%x, remote_ip=%pI6:%x, vlan=%x\n",

			   p_tcp_ramrod->tcp.local_ip,

			   p_tcp_ramrod->tcp.local_port,

			   p_tcp_ramrod->tcp.remote_ip,
@@ -1519,7 +1519,7 @@ qed_iwarp_print_cm_info(struct qed_hwfn *p_hwfn, 
			   cm_info->vlan);

	else

		DP_VERBOSE(p_hwfn, QED_MSG_RDMA,

			   "remote_ip %pI6h:%x, local_ip %pI6h:%x vlan=%x\n",

			   "remote_ip %pI6:%x, local_ip %pI6:%x vlan=%x\n",

			   cm_info->remote_ip, cm_info->remote_port,

			   cm_info->local_ip, cm_info->local_port,

			   cm_info->vlan);