Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91c5d67f authored by Dmitry Torokhov's avatar Dmitry Torokhov
Browse files

Input: tca8418_keypad - increase severity of failures in probe() 



Failures to build a keymap, request an IRQ, or register input device are
fatal for the driver, therefore the messages should have "error" severity
instead of "debug".

Reviewed-by: default avatarAlban Bedel <alban.bedel@avionic-design.de>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 5cc0dfe0

drivers/input/keyboard/tca8418_keypad.c

+3 −3
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static int tca8418_keypad_probe(struct i2c_client *client, 
	error = matrix_keypad_build_keymap(keymap_data, NULL, rows, cols,

					   keypad_data->keymap, input);

	if (error) {

		dev_dbg(dev, "Failed to build keymap\n");

		dev_err(dev, "Failed to build keymap\n");

		goto fail2;

	}
@@ -367,14 +367,14 @@ static int tca8418_keypad_probe(struct i2c_client *client, 
				     IRQF_ONESHOT,

				     client->name, keypad_data);

	if (error) {

		dev_dbg(dev, "Unable to claim irq %d; error %d\n",

		dev_err(dev, "Unable to claim irq %d; error %d\n",

			client->irq, error);

		goto fail2;

	}



	error = input_register_device(input);

	if (error) {

		dev_dbg(dev, "Unable to register input device, error: %d\n",

		dev_err(dev, "Unable to register input device, error: %d\n",

			error);

		goto fail3;

	}