Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 91acebed authored by Markus Elfring's avatar Markus Elfring Committed by David S. Miller
Browse files

net: pxa168_eth: Use kcalloc() in two functions 



Multiplications for the size determination of memory allocations
indicated that array data structures should be processed.
Thus use the corresponding function "kcalloc".

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dbbb2f03

drivers/net/ethernet/marvell/pxa168_eth.c

+2 −4
Original line number Diff line number Diff line
@@ -1036,8 +1036,7 @@ static int rxq_init(struct net_device *dev) 
	int rx_desc_num = pep->rx_ring_size;



	/* Allocate RX skb rings */

	pep->rx_skb = kzalloc(sizeof(*pep->rx_skb) * pep->rx_ring_size,

			     GFP_KERNEL);

	pep->rx_skb = kcalloc(rx_desc_num, sizeof(*pep->rx_skb), GFP_KERNEL);

	if (!pep->rx_skb)

		return -ENOMEM;
@@ -1096,8 +1095,7 @@ static int txq_init(struct net_device *dev) 
	int size = 0, i = 0;

	int tx_desc_num = pep->tx_ring_size;



	pep->tx_skb = kzalloc(sizeof(*pep->tx_skb) * pep->tx_ring_size,

			     GFP_KERNEL);

	pep->tx_skb = kcalloc(tx_desc_num, sizeof(*pep->tx_skb), GFP_KERNEL);

	if (!pep->tx_skb)

		return -ENOMEM;