Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9192d41a authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add --strict test for precedence challenged macro arguments 

Add a test for macro arguents that have a non-comma leading or trailing
operator where the argument isn't parenthesized to avoid possible precedence
issues.

Link: http://lkml.kernel.org/r/47715508972f8d786f435e583ff881dbeee3a114.1473745855.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent f59b64bf

scripts/checkpatch.pl

+8 −1
Original line number Diff line number Diff line
@@ -4836,7 +4836,7 @@ sub process { 
# check if any macro arguments are reused (ignore '...' and 'type')

			foreach my $arg (@def_args) {

			        next if ($arg =~ /\.\.\./);

			        next if ($arg =~ /^type$/);

			        next if ($arg =~ /^type$/i);

				my $tmp = $define_stmt;

				$tmp =~ s/\b(typeof|__typeof__|__builtin\w+|typecheck\s*\(\s*$Type\s*,|\#+)\s*\(*\s*$arg\s*\)*\b//g;

				$tmp =~ s/\#\s*$arg\b//g;
@@ -4846,6 +4846,13 @@ sub process { 
					CHK("MACRO_ARG_REUSE",

					    "Macro argument reuse '$arg' - possible side-effects?\n" . "$herectx");

				    }

# check if any macro arguments may have other precedence issues

				if ($define_stmt =~ m/($Operators)?\s*\b$arg\b\s*($Operators)?/m &&

				    ((defined($1) && $1 ne ',') ||

				     (defined($2) && $2 ne ','))) {

					CHK("MACRO_ARG_PRECEDENCE",

					    "Macro argument '$arg' may be better as '($arg)' to avoid precedence issues\n" . "$herectx");

				}

			}



# check for macros with flow control, but without ## concatenation